linux-kernel - Re: [PATCH] x86, mm: Avoid extra pxm_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1401260127370.15844@chino.kir.corp.google.com>
Date:	Sun, 26 Jan 2014 01:28:35 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Yinghai Lu <yinghai@...nel.org>
cc:	Ingo Molnar <mingo@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
	Toshi Kani <toshi.kani@...com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, mm: Avoid extra pxm_to_node()

On Sun, 26 Jan 2014, Yinghai Lu wrote:

> Index: linux-2.6/arch/x86/mm/srat.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/mm/srat.c
> +++ linux-2.6/arch/x86/mm/srat.c
> @@ -50,14 +50,19 @@ static __init inline int srat_disabled(v
>  void __init acpi_numa_slit_init(struct acpi_table_slit *slit)
>  {
>  	int i, j;
> +	int from_node, to_node;
>  
>  	for (i = 0; i < slit->locality_count; i++) {
> -		if (pxm_to_node(i) == NUMA_NO_NODE)
> +		from_node = pxm_to_node(i);
> +		if (from_node == NUMA_NO_NODE)
>  			continue;
> +
>  		for (j = 0; j < slit->locality_count; j++) {
> -			if (pxm_to_node(j) == NUMA_NO_NODE)
> +			to_node = pxm_to_node(j);
> +			if (to_node == NUMA_NO_NODE)
>  				continue;
> -			numa_set_distance(pxm_to_node(i), pxm_to_node(j),
> +
> +			numa_set_distance(from_node, to_node,
>  				slit->entry[slit->locality_count * i + j]);
>  		}
>  	}

Might as well make them "const" while you're at it by moving the 
definitions inside the iteration blocks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/