linux-kernel - Re: [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should depend on CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <1390811288.4974.4.camel@AMDC1943>
Date:	Mon, 27 Jan 2014 09:28:08 +0100
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Sangbeom Kim <sbkim73@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mfd: max14577: max14577_{suspend,resume}() should
 depend on CONFIG_PM_SLEEP

On Sun, 2014-01-26 at 11:38 +0100, Geert Uytterhoeven wrote:
> If CONFIG_PM_SLEEP=n:
> 
> drivers/mfd/max14577.c:177: warning: ‘max14577_suspend’ defined but not used
> drivers/mfd/max14577.c:200: warning: ‘max14577_resume’ defined but not used
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  drivers/mfd/max14577.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
> index ac514fb2b877..71aa14a6bfbb 100644
> --- a/drivers/mfd/max14577.c
> +++ b/drivers/mfd/max14577.c
> @@ -173,6 +173,7 @@ static const struct i2c_device_id max14577_i2c_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, max14577_i2c_id);
>  
> +#ifdef CONFIG_PM_SLEEP
>  static int max14577_suspend(struct device *dev)
>  {
>  	struct i2c_client *i2c = container_of(dev, struct i2c_client, dev);
> @@ -208,6 +209,7 @@ static int max14577_resume(struct device *dev)
>  
>  	return 0;
>  }
> +#endif /* CONFIG_PM_SLEEP */
>  
>  static struct of_device_id max14577_dt_match[] = {
>  	{ .compatible = "maxim,max14577", },

Same here:
http://thread.gmane.org/gmane.linux.kernel/1615513/focus=1615563
although I don't mind if your patch comes in :).

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/