linux-kernel - Re: [PATCH] misc: genwqe: Fix potential memory leak when pinning memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 27 Jan 2014 10:11:44 +0100
From:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
To:	Christian Engelmayer <cengelma@....at>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, haver@...ux.vnet.ibm.com
Subject: Re: [PATCH] misc: genwqe: Fix potential memory leak when pinning
 memory

Hi Christian,

Am Samstag, den 25.01.2014, 22:47 +0100 schrieb Christian Engelmayer:
> Fix a memory leak in the genwqe_pin_mem() error path as called by
> ioctl GENWQE_PIN_MEM. In case there is an error encountered when
> mapping memory, the already allocated dma_mapping struct needs to
> be freed correctly.
> 
> Detected by Coverity: CID 1162606.
> 
> Signed-off-by: Christian Engelmayer <cengelma@....at>
> ---
>  drivers/misc/genwqe/card_dev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/misc/genwqe/card_dev.c b/drivers/misc/genwqe/card_dev.c
> index 8f8a6b3..2c2c9cc 100644
> --- a/drivers/misc/genwqe/card_dev.c
> +++ b/drivers/misc/genwqe/card_dev.c
> @@ -787,6 +787,7 @@ static int genwqe_pin_mem(struct genwqe_file *cfile, struct genwqe_mem *m)
>  	if (rc != 0) {
>  		dev_err(&pci_dev->dev,
>  			"[%s] genwqe_user_vmap rc=%d\n", __func__, rc);
> +		kfree(dma_map);
>  		return rc;
>  	}
> 

thanks for discovering and fixing the problem.

Acked-by: Frank Haverkamp <haver@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/