linux-kernel - Re: [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sis9zm0c.fsf@rustcorp.com.au>
Date:	Mon, 27 Jan 2014 22:15:23 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Jan Engelhardt <jengelh@...i.de>
Cc:	Lucas De Marchi <lucas.de.marchi@...il.com>,
	Peter Chen <peter.chen@...escale.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async

Jan Engelhardt <jengelh@...i.de> writes:
> On Monday 2013-09-16 05:47, Rusty Russell wrote:
>>
>>Here's what I've got in my pending-rebases tree.
>>
>>@@ -842,6 +818,11 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
>> 		return -EFAULT;
>> 	name[MODULE_NAME_LEN-1] = '\0';
>> 
>>+	if (!(flags & O_NONBLOCK)) {
>>+		printk(KERN_WARNING
>>+		       "waiting module removal not supported: please upgrade");
>>+	}
>>+
>
> This patch has come to my attention via the opensuse lists, where
> a poster reported about this new user-visible message (it appears
> in dmesg!) and rightfully asked: upgrade what component?
>
> It's probably the userspace module loading utility, but it _really_
> should say so. There's good room to read that message - a few months
> into the future - as "upgrade your kernel" instead ;)

True, but honestly I never expected to see it!

Please try to discover what is doing rmmod --wait?

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/