linux-kernel - Re: [PATCH] perf tools: demangle kernel and kernel module symbols too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140127144812.GB3998@ghostprotocols.net>
Date:	Mon, 27 Jan 2014 11:48:12 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Avi Kivity <avi@...udius-systems.com>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] perf tools: demangle kernel and kernel module symbols too

Em Mon, Jan 27, 2014 at 04:14:24PM +0200, Avi Kivity escreveu:
> On 01/22/2014 09:58 PM, Avi Kivity wrote:
> >Some kernels contain C++ code, and thus their symbols need to be demangled.
> >This allows 'perf kvm top' to generate readable output.
> 
> Ping?

Applied, should be on my next pull req to Ingo,

- Arnaldo
 
> >Signed-off-by: Avi Kivity <avi@...udius-systems.com>
> >---
> >  tools/perf/util/symbol-elf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
> >index 7594567..8f12f0f 100644
> >--- a/tools/perf/util/symbol-elf.c
> >+++ b/tools/perf/util/symbol-elf.c
> >@@ -922,6 +922,7 @@ int dso__load_sym(struct dso *dso, struct map *map,
> >  				  (u64)shdr.sh_offset);
> >  			sym.st_value -= shdr.sh_addr - shdr.sh_offset;
> >  		}
> >+new_symbol:
> >  		/*
> >  		 * We need to figure out if the object was created from C++ sources
> >  		 * DWARF DW_compile_unit has this, but we don't always have access
> >@@ -933,7 +934,6 @@ int dso__load_sym(struct dso *dso, struct map *map,
> >  			if (demangled != NULL)
> >  				elf_name = demangled;
> >  		}
> >-new_symbol:
> >  		f = symbol__new(sym.st_value, sym.st_size,
> >  				GELF_ST_BIND(sym.st_info), elf_name);
> >  		free(demangled);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/