linux-kernel - Re: [PATCH v2] x86, kaslr: export offset in VMCOREINFO ELF notes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140127152557.GA27792@gmail.com>
Date:	Mon, 27 Jan 2014 16:25:57 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Kees Cook <keescook@...omium.org>, crash-utility@...hat.com,
	linux-kernel@...r.kernel.org, Dave Anderson <anderson@...hat.com>,
	Andrew Honig <ahonig@...gle.com>,
	Eugene Surovegin <surovegin@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Yinghai Lu <yinghai@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Namhyung Kim <namhyung@...nel.org>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH v2] x86, kaslr: export offset in VMCOREINFO ELF notes


* Adrian Hunter <adrian.hunter@...el.com> wrote:

> On 25/01/14 09:47, Ingo Molnar wrote:
> > 
> > * Kees Cook <keescook@...omium.org> wrote:
> > 
> >> From: Eugene Surovegin <surovegin@...gle.com>
> >>
> >> Include kASLR offset in VMCOREINFO ELF notes to assist in debugging.
> >>
> >> Signed-off-by: Eugene Surovegin <surovegin@...gle.com>
> >> Signed-off-by: Kees Cook <keescook@...omium.org>
> >> ---
> >> v2:
> >>  - make sure "From:" got sent correctly
> >> ---
> >>  arch/x86/kernel/machine_kexec_64.c |    2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c
> >> index 4eabc160696f..679cef0791cd 100644
> >> --- a/arch/x86/kernel/machine_kexec_64.c
> >> +++ b/arch/x86/kernel/machine_kexec_64.c
> >> @@ -279,5 +279,7 @@ void arch_crash_save_vmcoreinfo(void)
> >>  	VMCOREINFO_SYMBOL(node_data);
> >>  	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
> >>  #endif
> >> +	vmcoreinfo_append_str("KERNELOFFSET=%lx\n",
> >> +			      (unsigned long)&_text - __START_KERNEL);
> >>  }
> > 
> > I've Cc:-ed Adrian Hunter, who has sent the following kaslr fixes for 
> > perf yesterday:
> > 
> >   http://lkml.org/lkml/2014/1/24/220
> > 
> > Adrian, is this patch the right solution from the perf tooling 
> > perspective?
> 
> perf tools isn't a consumer of VMCOREINFO although I see VMCOREINFO 
> already has _stext which would be enough for many purposes.

Yes - but let me explain where I'm coming from: I'd like the recent 
KASLR related perf /proc/kcore based annotation bug to be fixed 
properly.

Currently I'm not sure about the status of it. In your fixes 
submission:

  Date: Fri, 24 Jan 2014 17:10:10 +0200
  From: Adrian Hunter <adrian.hunter@...el.com>
  Subject: [PATCH 0/8] perf tools: kaslr fixes

you mentioned the following:

    "- mustn't use kcore if the kernel has moved"

Does this that /proc/kcore annotation will not work if KASLR is 
active?

If yes then given that I expect most distros to turn on KASLR this 
would essentially make /proc/kcore useless on a large set of Linux 
systems. That would be suboptimal.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/