linux-kernel - Re: [PATCH 2/4] Input: zforce - fix lines exceeding 80 columns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1864335.qYXGSfrppl@phil>
Date:	Mon, 27 Jan 2014 20:12:48 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	Luis Ortega <luiorpe1@....es>
Cc:	dmitry.torokhov@...il.com, yongjun_wei@...ndmicro.com.cn,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] Input: zforce - fix lines exceeding 80 columns

On Monday, 27. January 2014 19:46:11 Luis Ortega wrote:
> Fixed lines exceeding 80 characters long wherever possible,
> as per the coding style.
> 
> Signed-off-by: Luis Ortega <luiorpe1@....es>

checkpatch did not complain on the initial submission, so I guess it's more an 
issue of taste. Nevertheless I don't have a preference for one way or the 
other, so

Acked-by: Heiko Stuebner <heiko@...ech.de>


> ---
>  drivers/input/touchscreen/zforce_ts.c | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/zforce_ts.c
> b/drivers/input/touchscreen/zforce_ts.c index c145c1d..c1b6b82 100644
> --- a/drivers/input/touchscreen/zforce_ts.c
> +++ b/drivers/input/touchscreen/zforce_ts.c
> @@ -235,7 +235,8 @@ static int zforce_scan_frequency(struct zforce_ts *ts,
> u16 idle, u16 finger, (finger & 0xff), ((finger >> 8) & 0xff),
>  			(stylus & 0xff), ((stylus >> 8) & 0xff) };
> 
> -	dev_dbg(&client->dev, "set scan frequency to (idle: %d, finger: %d,
> stylus: %d)\n", +	dev_dbg(&client->dev,
> +		"set scan frequency to (idle: %d, finger: %d, stylus: %d)\n",
>  		idle, finger, stylus);
> 
>  	return zforce_send_wait(ts, &buf[0], ARRAY_SIZE(buf));
> @@ -332,7 +333,8 @@ static int zforce_touch_event(struct zforce_ts *ts, u8
> *payload)
> 
>  	count = payload[0];
>  	if (count > ZFORCE_REPORT_POINTS) {
> -		dev_warn(&client->dev, "too many coordinates %d, expected max %d\n",
> +		dev_warn(&client->dev,
> +			 "too many coordinates %d, expected max %d\n",
>  			 count, ZFORCE_REPORT_POINTS);
>  		count = ZFORCE_REPORT_POINTS;
>  	}
> @@ -494,8 +496,8 @@ static irqreturn_t zforce_irq_thread(int irq, void
> *dev_id) while (!gpio_get_value(pdata->gpio_int)) {
>  		ret = zforce_read_packet(ts, payload_buffer);
>  		if (ret < 0) {
> -			dev_err(&client->dev, "could not read packet, ret: %d\n",
> -				ret);
> +			dev_err(&client->dev,
> +				"could not read packet, ret: %d\n", ret);
>  			break;
>  		}
> 
> @@ -539,7 +541,8 @@ static irqreturn_t zforce_irq_thread(int irq, void
> *dev_id) payload[RESPONSE_DATA + 4];
>  			ts->version_rev   = (payload[RESPONSE_DATA + 7] << 8) |
>  						payload[RESPONSE_DATA + 6];
> -			dev_dbg(&ts->client->dev, "Firmware Version %04x:%04x %04x:
%04x\n",
> +			dev_dbg(&ts->client->dev,
> +				"Firmware Version %04x:%04x %04x:%04x\n",
>  				ts->version_major, ts->version_minor,
>  				ts->version_build, ts->version_rev);
> 
> @@ -552,7 +555,8 @@ static irqreturn_t zforce_irq_thread(int irq, void
> *dev_id) break;
> 
>  		default:
> -			dev_err(&ts->client->dev, "unrecognized response id: 0x%x\n",
> +			dev_err(&ts->client->dev,
> +				"unrecognized response id: 0x%x\n",
>  				payload[RESPONSE_ID]);
>  			break;
>  		}
> @@ -618,7 +622,8 @@ static int zforce_suspend(struct device *dev)
> 
>  		enable_irq_wake(client->irq);
>  	} else if (input->users) {
> -		dev_dbg(&client->dev, "suspend without being a wakeup source\n");
> +		dev_dbg(&client->dev,
> +			"suspend without being a wakeup source\n");
> 
>  		ret = zforce_stop(ts);
>  		if (ret)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/