linux-kernel - Re: [RFC][PATCH] module: allow multiple calls to MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jan 2014 11:54:22 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Tom Gundersen <teg@...m.no>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	kay@...y.org, Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [RFC][PATCH] module: allow multiple calls to
 MODULE_DEVICE_TABLE() per module

On Mon, Jan 27, 2014 at 08:09:55PM +0100, Tom Gundersen wrote:
> Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where the
> second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all
> the modaliases being exposed.
> 
> This fixes the problem by including the name of the device_id table in the
> __mod_*_device_table alias, allowing us to export several device_id tables
> per module.
> 
> Suggested-by: Kay Sievers <kay@...y.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Rusty Russell <rusty@...tcorp.com.au>
> ---
>  include/linux/module.h   |  2 +-
>  scripts/mod/file2alias.c | 14 +++++++++-----
>  2 files changed, 10 insertions(+), 6 deletions(-)

Ah, very nice, I've wanted this for a while now, it would make a number
of different drivers much smaller and simpler to add new device ids to
(no multiple lists of ids, one for the module loader and one for the
sub-driver that is in the single file.)

If this doesn't break any userspace tools, I have no objection to it at
all:

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/