linux-kernel - Re: [PATCH v2 7/7] ASoC: binding: for new properties documenting and usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140127195848.GB11841@sirena.org.uk>
Date:	Mon, 27 Jan 2014 19:58:48 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	lgirdwood@...il.com, kuninori.morimoto.gx@...esas.com,
	rob@...dley.net, perex@...ex.cz, moinejf@...e.fr,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH v2 7/7] ASoC: binding: for new properties documenting and
 usage

On Fri, Jan 24, 2014 at 03:43:06PM +0800, Xiubo Li wrote:
> This add the following three new properties documenting and usage
> for simple card:
> 
> 	"simple-audio-card,name",
> 	"simple-audio-card,widgets",
> 	"simple-audio-card,tdm-slot".

name and widgets are basically fine modulo the comment about "Hp".
tdm-slot needs further study, when resubmitting can you please split
that into a second patch so that the name and widgets properties can be
merged even if that needs more work?

For widgets it might be good to create a separate document widgets.txt
and refer to that - since the code in the kernel can be shared and
extended we should share the binding document too.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)