linux-kernel - Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140127225004.GA17970@kroah.com>
Date:	Mon, 27 Jan 2014 14:50:04 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	xypron.glpk@....de
Cc:	devel@...verdev.osuosl.org, linux-usb@...r.kernel.org,
	ly80toro@....cs.fau.de, linux-kernel@...r.kernel.org,
	ke42caxa@....cs.fau.de
Subject: Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.glpk@....de wrote:
> From: Heinrich Schuchardt <xypron.glpk@....de>
> 
> p is freed if NULL.

Not a real problem, right?

> p is leaked if second calloc fails.

You just created a new bug in your "fix" :(

Please run your patches through scripts/checkpatch.pl, odds are, it
would have caught this error.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/