linux-kernel - Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1390899572.20150.97.camel@joe-AO722>
Date:	Tue, 28 Jan 2014 00:59:32 -0800
From:	Joe Perches <joe@...ches.com>
To:	liujunliang_ljl@....com
Cc:	davem@...emloft.net, horms@...ge.net.au, romieu@...zoreil.com,
	gregkh@...uxfoundation.org, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	sunhecheng@....126.com
Subject: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800
 Device Driver Support

On Tue, 2014-01-28 at 16:36 +0800, liujunliang_ljl@....com wrote:
> From: Liu Junliang <liujunliang_ljl@....com>

trivial comments...

> diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c

[]

> +static int sr_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
> +{
[]
> +		if (size != ((~header >> 16) & 0x07ff)) {
> +			netdev_err(dev->net,
> +				   "sr_rx_fixup() Bad Header Length\n");

printks with embedded functions names are
generally better using "%s: ", __func__

			netdev_err(dev->net, "%s: Bad header length\n",
				   __func__);

[]

> +			netdev_err(dev->net,
> +				   "sr_rx_fixup() Bad RX Length %d\n", size);

etc.

> +	if (skb->len != offset) {
> +		netdev_err(dev->net, "sr_rx_fixup() Bad SKB Length %d\n",
> +			   skb->len);

etc.

[]

> +static inline int sr9800_set_default_mode(struct usbnet *dev)
> +{

rather a big function to inline

[]

> +	if (ret < 0) {
> +		netdev_dbg(dev->net, "Write IPG,IPG1,IPG2 failed: %d", ret);

missing newline terminations

> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x after all initializations",
> +		   rx_ctl);

etc...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/