linux-kernel - Re: [PATCH] xen/gnttab: Use phys_addr_t to describe the grant frame base address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1390901746.7753.5.camel@kazak.uk.xensource.com>
Date:	Tue, 28 Jan 2014 09:35:46 +0000
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Julien Grall <julien.grall@...aro.org>
CC:	<linux-kernel@...r.kernel.org>, <konrad.wilk@...cle.com>,
	<boris.ostrovsky@...cle.com>, <david.vrabel@...rix.com>,
	<xen-devel@...ts.xenproject.org>,
	<stefano.stabellini@...citrix.com>, <patches@...aro.org>
Subject: Re: [PATCH] xen/gnttab: Use phys_addr_t to describe the grant frame
 base address

On Tue, 2014-01-28 at 01:03 +0000, Julien Grall wrote:
> On ARM, address size can be 32 bits or 64 bits (if CONFIG_ARCH_PHYS_ADDR_T_64BIT
> is enabled).
> We can't assume that the grant frame base address will always fits in an
> unsigned long. Use phys_addr_t instead of unsigned long as argument for
> gnttab_setup_auto_xlat_frames.

Strictly speaking I think it would be wrong for the tools to provide a
grant frame address which only kernels with LPAE support enabled could
use, so the issue is more theoretical than a real danger.

The patch is still correct though.

> Signed-off-by: Julien Grall <julien.grall@...aro.org>

Acked-by: Ian Campbell <ian.campbell@...rix.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/