linux-kernel - Re: [PATCH] for_each macros correctness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140128120245.GB4280@osiris>
Date:	Tue, 28 Jan 2014 13:02:45 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Jose Alonso <joalonsof@...il.com>
Cc:	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Lukasz Dorau <lukasz.dorau@...el.com>,
	Maciej Patelczyk <maciej.patelczyk@...el.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] for_each macros correctness

On Sun, Jan 26, 2014 at 08:54:18AM -0200, Jose Alonso wrote:
> 
> I observed that there are for_each macros that do an extra memory access
> beyond the defined area.
> Normally this does not cause problems.
> But, this can cause exceptions. For example: if the area is allocated at
> the end of a page and the next page is not accessible.
> 
> For correctness, I suggest changing the arguments of the 'for loop' like
> others 'for_each' do in the kernel.
> 
> files involved:
>    drivers/s390/cio/qdio.h
>    drivers/scsi/isci/host.h
>    drivers/sh/clk/core.c
>    include/linux/blk-mq.h
>    include/linux/shdma-base.h
>    sound/soc/sh/rcar/adg.c
> 
> 
> Signed-off-by: Jose Alonso <joalonsof@...il.com>
> ---
> diff --git a/drivers/s390/cio/qdio.h b/drivers/s390/cio/qdio.h
> index 8acaae1..a563e4c 100644
> --- a/drivers/s390/cio/qdio.h
> +++ b/drivers/s390/cio/qdio.h
> @@ -359,14 +359,12 @@ static inline int multicast_outbound(struct qdio_q *q)
>  #define need_siga_sync_out_after_pci(q)	\
>  	(unlikely(q->irq_ptr->siga_flag.sync_out_after_pci))
> 
> -#define for_each_input_queue(irq_ptr, q, i)	\
> -	for (i = 0, q = irq_ptr->input_qs[0];	\
> -		i < irq_ptr->nr_input_qs;	\
> -		q = irq_ptr->input_qs[++i])
> -#define for_each_output_queue(irq_ptr, q, i)	\
> -	for (i = 0, q = irq_ptr->output_qs[0];	\
> -		i < irq_ptr->nr_output_qs;	\
> -		q = irq_ptr->output_qs[++i])
> +#define for_each_input_queue(irq_ptr, q, i)		\
> +	for (i = 0; i < irq_ptr->nr_input_qs &&		\
> +		({ q = irq_ptr->input_qs[i]; 1; }); i++)
> +#define for_each_output_queue(irq_ptr, q, i)		\
> +	for (i = 0; i < irq_ptr->nr_output_qs &&	\
> +		({ q = irq_ptr->output_qs[i]; 1; }); i++)

Hi Jose,

I generated a single commit of this part of your patch and applied
it to the s390 git tree.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/