linux-kernel - Re: [PATCH 5/9] sched: Push put_prev_task() into pick_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140128191459.GF11314@laptop.programming.kicks-ass.net>
Date:	Tue, 28 Jan 2014 20:14:59 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	bsegall@...gle.com
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org,
	daniel.lezcano@...aro.org, pjt@...gle.com,
	Steven Rostedt <rostedt@...dmis.org>,
	Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH 5/9] sched: Push put_prev_task() into pick_next_task()

On Tue, Jan 28, 2014 at 10:46:18AM -0800, bsegall@...gle.com wrote:
> > @@ -4734,7 +4729,7 @@ static void migrate_tasks(unsigned int d
> >  		if (rq->nr_running == 1)
> >  			break;
> >  
> > -		next = pick_next_task(rq);
> > +		next = pick_next_task(rq, NULL);
> 
> This seems to be incorrect without the if (prev) lines in
> pick_next_task_foo, since foo_nr_running isn't enough to save us.

ARgh, I knew there must've been a reason I had those :/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/