linux-kernel - Re: [PATCH] memblock: Add limit checking to memblock_virt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140128140839.733d94150b99aaf7ac08bf96@linux-foundation.org>
Date:	Tue, 28 Jan 2014 14:08:39 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	"'Russell King - ARM Linux'" <linux@....linux.org.uk>,
	Kevin Hilman <khilman@...aro.org>,
	Olof Johansson <olof@...om.net>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Dave Hansen <dave.hansen@...el.com>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	linux-kernel@...r.kernel.org, Kevin Hilman <khilman@...aro.org>,
	Olof Johansson <olof@...om.net>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Subject: Re: [PATCH] memblock: Add limit checking to memblock_virt_alloc

On Tue, 28 Jan 2014 14:04:25 -0800 Yinghai Lu <yinghai@...nel.org> wrote:

> In original bootmem wrapper for memblock, we have limit checking.
> 
> Add it to memblock_virt_alloc, to address arm and x86 booting crash.
> 
> ...
>
> --- linux-2.6.orig/mm/memblock.c
> +++ linux-2.6/mm/memblock.c
> @@ -1077,6 +1077,9 @@ static void * __init memblock_virt_alloc
>  	if (!align)
>  		align = SMP_CACHE_BYTES;
>  
> +	if (max_addr > memblock.current_limit)
> +		max_addr = memblock.current_limit;
> +
>  again:
>  	alloc = memblock_find_in_range_node(size, align, min_addr, max_addr,
>  					    nid);

Thanks.

Kevin, Olof and Konrad (at least) have been hitting this.  It would be
great to get some tested-by's, please?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/