linux-kernel - Re: [PATCH V3 1/2] devres: introduce API "devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKDJKT7xSscxGaRrLqQYtNv6c86iV0i8h+OFaspyp3fkPsHyKg@mail.gmail.com>
Date:	Wed, 29 Jan 2014 17:25:40 +0530
From:	Manish Badarkhe <badarkhe.manish@...il.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Joe Perches <joe@...ches.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	gregkh@...uxfoundation.org, Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH V3 1/2] devres: introduce API "devm_kstrdup"

Hi Mark,

On Wed, Jan 29, 2014 at 5:10 PM, Mark Brown <broonie@...nel.org> wrote:
> On Wed, Jan 29, 2014 at 04:38:20PM +0530, Manish Badarkhe wrote:
>> On Wed, Jan 29, 2014 at 9:48 AM, Joe Perches <joe@...ches.com> wrote:
>
>> >> +     buf = devm_kzalloc(dev, size, gfp);
>
>> > If this is really necessary, please use devm_kmalloc
>
>> devm_kzalloc is always better giving zeroed memory locations.
>> Is there any reason not to go for it?
>
> If the allocated memory is going to be immediately overwritten with the
> string then it shouldn't make any difference if it was zeroed when
> allocated.

Thank you for clarification. I will go ahead to make it devm_kmalloc
and post a new version of patch.

Regards
Manish Badarkhe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/