linux-kernel - Re: kernfs: lockdep complains about kernfs_addrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140129182247.GN30842@htj.dyndns.org>
Date:	Wed, 29 Jan 2014 13:22:47 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: kernfs: lockdep complains about kernfs_addrm_ctx

Hello, Jiri.

On Wed, Jan 22, 2014 at 03:01:38PM +0100, Jiri Kosina wrote:
> booting with current Linus' tree (df32e43a5) gives me this:
> 
>  INFO: trying to register non-static key.
>  the code is fine but needs lockdep annotation.
>  turning off the locking correctness validator.
>  CPU: 1 PID: 105 Comm: udevd Not tainted 3.13.0-03477-gdf32e43 #1
>  Hardware name: LENOVO 7470BN2/7470BN2, BIOS 6DET38WW (2.02 ) 12/19/2008
>   0000000000000000 ffff880037ad3468 ffffffff8159701b ffff880037ad34e8
>   ffffffff8109e317 0000000000000000 ffff880037ad4fd0 ffff880037ad34e8
>   0000000000000000 ffff880037ad34b8 ffffffff00000000 0000000000000002
>  Call Trace:
>   [<ffffffff8159701b>] dump_stack+0x72/0x87
>   [<ffffffff8109e317>] register_lock_class+0x497/0x4c0
>   [<ffffffff810a1c2d>] __lock_acquire+0x7d/0x600
>   [<ffffffff810a0cdd>] ? trace_hardirqs_on_caller+0x13d/0x1e0
>   [<ffffffff810a22a1>] lock_acquire+0xf1/0x120
>   [<ffffffff81215460>] ? kernfs_addrm_finish+0x30/0x50
>   [<ffffffff81214cf9>] kernfs_deactivate+0xe9/0x130
...
> 
> I have started to look into the kernfs code now to debug this, but as I 
> haven't been following it closely during the review phase, it might take 
> some time before I familiarize myself with it; hence sending this as a 
> heads-up.

Oops, this got reported again and the fix patch has been posted
earlier today.

 http://lkml.kernel.org/g/<20140129170403.GJ30842@....dyndns.org>

Can you please see whether the above patch fixes the issue?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/