linux-kernel - Re: [PATCH v3 1/2] qspinlock: Introducing a 4-byte queue spinlock implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	28 Jan 2014 21:57:40 -0500
From:	"George Spelvin" <linux@...izon.com>
To:	andi@...stfloor.org, Waiman.Long@...com
Cc:	akpm@...ux-foundation.org, arnd@...db.de, aswin@...com,
	daniel@...ascale.com, halcy@...dex.ru, hpa@...or.com,
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux@...izon.com, mingo@...hat.com, paulmck@...ux.vnet.ibm.com,
	peterz@...radead.org, raghavendra.kt@...ux.vnet.ibm.com,
	riel@...hat.com, rostedt@...dmis.org, scott.norton@...com,
	tglx@...utronix.de, thavatchai.makpahibulchoke@...com,
	tim.c.chen@...ux.intel.com, torvalds@...ux-foundation.org,
	walken@...gle.com, x86@...nel.org
Subject: Re: [PATCH v3 1/2] qspinlock: Introducing a 4-byte queue spinlock implementation

> So the 1-2 threads case is the standard case on a small
> system, isn't it? This may well cause regressions.

Well, the common case should be uncontended, which is faster.
But yes, testing would be nice.

>> In the extremely unlikely case that all the queue node entries are
>> used up, the current code will fall back to busy spinning without
>> waiting in a queue with warning message.

> Traditionally we had some code which could take thousands
> of locks in rare cases (e.g. all locks in a hash table or all locks of
> a big reader lock) 

Doesn't apply; the question implies a misunderstanding of what's
happening.  The entry is only needed while spinning waiting for
the lock.  Once the lock has been acquired, it may be recycled.

The thread may *hold* thousands of locks; the entries only apply
to locks being *waited for*.

>From process context a thread may only be waiting for one at a time.
Additional entries are only needed in case a processor takes an interrupt
while spinning, and the interrupt handler wants to take a lock, too.

If that lock also has to be waited for, and during the wait you take a
nested interrupt or NMI, a third level might happen.

The chances of this being nested more than 4 deep seem sufficiently
minute.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/