linux-kernel - Re: [PATCH V3 4/8] phy: Initialize phy core with subsys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Jan 2014 17:13:37 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Mohit Kumar <mohit.kumar@...com>, <arnd@...db.de>
CC:	Pratyush Anand <pratyush.anand@...com>, <spear-devel@...t.st.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 4/8] phy: Initialize phy core with subsys_initcall

Hi,

On Thursday 30 January 2014 04:18 PM, Mohit Kumar wrote:
> From: Pratyush Anand <pratyush.anand@...com>
> 
> PCIe RC drivers are initialized with subsys_initcall. Few PCIe drivers
> like SPEAr13xx needs phy drivers to be initialized.

Instead change PCIe RC drivers to module init. Phy drivers should be loaded
very early otherwise. (Hint: drivers/Makefile).

Thanks
Kishon
> 
> Therefore initialize phy core driver with subsys_initcall to avoid
> calling of phy_get before phy_class is created.
> 
> Signed-off-by: Pratyush Anand <pratyush.anand@...com>
> Cc: Mohit Kumar <mohit.kumar@...com>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: spear-devel@...t.st.com
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/phy/phy-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
> index 03cf8fb..fa73101 100644
> --- a/drivers/phy/phy-core.c
> +++ b/drivers/phy/phy-core.c
> @@ -685,7 +685,7 @@ static int __init phy_core_init(void)
>  
>  	return 0;
>  }
> -module_init(phy_core_init);
> +subsys_initcall(phy_core_init);
>  
>  static void __exit phy_core_exit(void)
>  {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/