linux-kernel - Re: About gpio-regulator setting on DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140130121251.GO22609@sirena.org.uk>
Date:	Thu, 30 Jan 2014 12:12:51 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Kuninori Morimoto <kuninori.morimoto.gx@...il.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Lee Jones <lee.jones@...aro.org>, Simon <horms@...ge.net.au>,
	Magnus <magnus.damm@...il.com>,
	Linux-SH <linux-sh@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: About gpio-regulator setting on DT

On Wed, Jan 29, 2014 at 04:08:30PM -0800, Kuninori Morimoto wrote:

>     /* build initial state from gpio init data. */
>     state = 0;
>     for (ptr = 0; ptr < drvdata->nr_gpios; ptr++) {
>         if (config->gpios[ptr].flags & GPIOF_OUT_INIT_HIGH)     <== we need this
>                state |= (1 << ptr);
>     }
>     drvdata->state = state;

So this just looks like a bug in the code - the DT has all the data
needed but the parsing code isn't setting everything up that the rest of
the code needs and/or we should drop one of the ways of configuring
things in the main probe function.  Avoiding having two ways of doing
the same thing in the main probe would definitely be good.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)