lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Jan 2014 18:01:54 +0100 From: Pavel Machek <pavel@....cz> To: Jenny TC <jenny.tc@...el.com> Cc: linux-kernel@...r.kernel.org, Dmitry Eremin-Solenikov <dbaryshkov@...il.com>, Anton Vorontsov <cbouatmailru@...il.com>, Anton Vorontsov <anton.vorontsov@...aro.org>, Kim Milo <Milo.Kim@...com>, Lee Jones <lee.jones@...aro.org>, Jingoo Han <jg1.han@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>, Sachin Kamat <sachin.kamat@...aro.org>, Lars-Peter Clausen <lars@...afoo.de>, Pali Rohár <pali.rohar@...il.com>, Rhyland Klein <rklein@...dia.com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, David Woodhouse <dwmw2@...radead.org>, Tony Lindgren <tony@...mide.com>, Russell King <linux@....linux.org.uk>, Sebastian Reichel <sre@...g0.de>, aaro.koskinen@....fi, freemangordon@....bg, linux-omap@...r.kernel.org Subject: Re: [PATCH 4/4] power_supply: bq24261 charger driver Hi! > diff --git a/drivers/power/Makefile b/drivers/power/Makefile > index 77535fd..6d184c8 100644 > --- a/drivers/power/Makefile > +++ b/drivers/power/Makefile > @@ -59,4 +59,5 @@ obj-$(CONFIG_CHARGER_BQ24735) += bq24735-charger.o > obj-$(CONFIG_POWER_AVS) += avs/ > obj-$(CONFIG_CHARGER_SMB347) += smb347-charger.o > obj-$(CONFIG_CHARGER_TPS65090) += tps65090-charger.o > +obj-$(CONFIG_BQ24261_CHARGER) += bq24261_charger.o > obj-$(CONFIG_POWER_RESET) += reset/ I believe I commented on this one before. Spot two inconsistencies. > + int (*set_inlmt) (int val); > + int (*set_iterm) (int val); And stop using cryptic names. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists