linux-kernel - Re: [PATCH] pinctrl: Quiet logging about missing DT nodes when not using DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1391108694.2422.59.camel@joe-AO722>
Date:	Thu, 30 Jan 2014 11:04:54 -0800
From:	Joe Perches <joe@...ches.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org,
	Mark Brown <broonie@...aro.org>
Subject: Re: [PATCH] pinctrl: Quiet logging about missing DT nodes when not
 using DT

On Thu, 2014-01-30 at 18:57 +0000, Mark Brown wrote:
> From: Mark Brown <broonie@...aro.org>
> 
> On systems which were not booted using DT it is entirely unsurprising that
> device nodes don't have any DT information and this is going to happen for
> every single device in the system. Make pinctrl be less chatty about this
> situation by only logging in the case where we have DT.

trivia:

> diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c
[]
> @@ -186,7 +186,9 @@ int pinctrl_dt_to_map(struct pinctrl *p)
>  
>  	/* CONFIG_OF enabled, p->dev not instantiated from DT */
>  	if (!np) {
> -		dev_dbg(p->dev, "no of_node; not parsing pinctrl DT\n");
> +		if (of_have_populated_dt())
> +			dev_dbg(p->dev,
> +				"no of_node; not parsing pinctrl DT\n");

There are 80 columns.  It's OK to use them all.

			dev_dbg(p->dev, "no of_node; not parsing pinctrl DT\n");


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/