linux-kernel - Re: [PATCH v4 1/2] mm: add kstrimdup function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Jan 2014 19:41:37 -0800
From:	Sebastian Capella <sebastian.capella@...aro.org>
To:	Joe Perches <joe@...ches.com>,
	"Mikulas Patocka" <mpatocka@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-pm@...r.kernel.org, linaro-kernel@...ts.linaro.org,
	patches@...aro.org, "Andrew Morton" <akpm@...ux-foundation.org>,
	"Michel Lespinasse" <walken@...gle.com>,
	"Shaohua Li" <shli@...nel.org>,
	"Jerome Marchand" <jmarchan@...hat.com>,
	"Joonsoo Kim" <iamjoonsoo.kim@....com>
Subject: Re: [PATCH v4 1/2] mm: add kstrimdup function

Quoting Joe Perches (2014-01-29 17:24:28)
> Why not minimize the malloc length too?
> 
> maybe something like:
> 
> char *kstrimdup(const char *s, gfp_t gfp)
> {
>         char *buf;
>         const char *begin = skip_spaces(s);
>         size_t len = strlen(begin);
> 
>         while (len && isspace(begin[len - 1]))
>                 len--;
> 
>         buf = kmalloc_track_caller(len + 1, gfp);
>         if (!buf)
>                 return NULL;
> 
>         memcpy(buf, begin, len);
>         buf[len] = 0;
> 
>         return buf;
> }

I figured it would be mostly for small trimming, but it seems like
it could be and advantage and used more generally this way.

I have a couple of small changes to return NULL in empty string/all ws
cases and fix a buffer underrun.

How does this look?

Thanks,

Sebastian


char *kstrimdup(const char *s, gfp_t gfp)
{                                                                                
        char *buf;                                                               
        const char *begin = skip_spaces(s);                                      
        size_t len = strlen(begin);                                              

        if (len == 0)                                                            
                return NULL;                                                     
                                                                                 
        while (len > 1 && isspace(begin[len - 1]))                               
                len--;                                                           
                                                                                 
        buf = kmalloc_track_caller(len + 1, gfp);                                
        if (!buf)                                                                
                return NULL;                                                     
                                                                                 
        memcpy(buf, begin, len);                                                 
        buf[len] = '\0';                                                            
                                                                                 
        return buf;                                                              
}        



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/