[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20140130141538.a9e3977b5e7b76bdcf59a15f@linux-foundation.org>
Date: Thu, 30 Jan 2014 14:15:38 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: David Rientjes <rientjes@...gle.com>
Cc: Vladimir Davydov <vdavydov@...allels.com>, mhocko@...e.cz,
linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memcg: fix mutex not unlocked on
memcg_create_kmem_cache fail path
On Thu, 30 Jan 2014 14:13:18 -0800 (PST) David Rientjes <rientjes@...gle.com> wrote:
> On Thu, 30 Jan 2014, Andrew Morton wrote:
>
> > > Why? We already construct the name in memcg_create_kmem_cache()
> > > appropriately, we just want to avoid the kstrdup() in
> > > kmem_cache_create_memcg() since it's pointless like my patch does.
> >
> > oh, OK, missed that.
> >
> > The problem now is that the string at kmem_cache.name is PATH_MAX
> > bytes, and PATH_MAX is huuuuuuuge.
> >
>
> It always was.
eh? kmem_cache_create_memcg()'s kstrdup() will allocate the minimum
needed amount of memory.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists