| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Jan 2014 14:39:47 -0800 From: Sarah Sharp <sarah.a.sharp@...ux.intel.com> To: David Laight <David.Laight@...LAB.COM> Cc: 'Mathias Nyman' <mathias.nyman@...ux.intel.com>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, "dan.j.williams@...el.com" <dan.j.williams@...el.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [RFCv2 00/10] xhci: re-work command queue management On Thu, Jan 30, 2014 at 02:25:48PM +0000, David Laight wrote: > I think it would be much simpler to allocate a parallel array to the actual > hardware command ring that contains the additional information for the request > (instead of allocating it pre-request). > This would immediately solve any problems allocating the memory from interrupt > context and failing to free in correctly in all the code paths. > > A similar solution could be used for the transfer rings thus removing the > need to the 'td' list - which there are reports of it failing to find transfers > and the code paths for aborting isoch transfers are badly broken. > > Adding another list that will have its own set of bugs seems retrograde top me. I do not have a problem with it. The shadow ring is an optimization we can look at later. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists