linux-kernel - Re: [PATCH v4] HID: New hid-cp2112 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1401311138400.27155@pobox.suse.cz>
Date:	Fri, 31 Jan 2014 11:41:17 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	David Barksdale <dbarksdale@...ogix.com>
cc:	David Herrmann <dh.herrmann@...il.com>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Oliver Neukum <oliver@...kum.org>,
	Jakub Kákona <kjakub@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] HID: New hid-cp2112 driver

On Wed, 29 Jan 2014, David Barksdale wrote:

> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 34e2d39..246a233 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -175,6 +175,15 @@ config HID_PRODIKEYS
>  	  multimedia keyboard, but will lack support for the musical keyboard
>  	  and some additional multimedia keys.
>  
> +config HID_CP2112
> +	tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> +	depends on USB_HID

Dependency on I2C is necessary as well, isn't it?

Other than that, it looks good to me.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/