linux-kernel - Re: [PATCH] gpio: bcm281xx: Use "unsigned gpio" consistently throughout the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYjErY-A-1U=QRas5jXH7SS8mteX2uxe_3HdcrVBCJisg@mail.gmail.com>
Date:	Fri, 31 Jan 2014 12:40:56 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Markus Mayer <markus.mayer@...aro.org>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	Linaro Patches <patches@...aro.org>,
	Linux GPIO List <linux-gpio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Tim Kryger <tim.kryger@...aro.org>
Subject: Re: [PATCH] gpio: bcm281xx: Use "unsigned gpio" consistently
 throughout the code

On Tue, Jan 28, 2014 at 2:32 AM, Markus Mayer <markus.mayer@...aro.org> wrote:

> This patch removes some inconsistencies caused by the use of "int gpio"
> in some parts of the code and "unsigned gpio" in others.
>
> Signed-off-by: Markus Mayer <markus.mayer@...aro.org>
> Reviewed-by: Tim Kryger <tim.kryger@...aro.org>

Patch applied, nice for static syntax checkers.

But the variable should probably be renamed from
"gpio" to "offset" since it's a local offset number on this
very GPIO block, not the global GPIO numberspace.

No big deal though.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/