linux-kernel - Re: [PATCH 2/3 v2] pinctrl-adi2: change irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb4Ogf5a-akRhtGgsZuFDY9ba9Jx_nyhUpYo7M9yFRy5w@mail.gmail.com>
Date:	Fri, 31 Jan 2014 13:42:10 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Sonic Zhang <sonic.adi@...il.com>
Cc:	Steven Miao <realmz6@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	adi-buildroot-devel@...ts.sourceforge.net,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH 2/3 v2] pinctrl-adi2: change irq_base from usigned int to int

On Tue, Jan 28, 2014 at 4:02 AM, Sonic Zhang <sonic.adi@...il.com> wrote:

> From: Sonic Zhang <sonic.zhang@...log.com>
>
> Negative irq_base means there is no fixed Linux irq mappings are created from the platform data.
> The driver calls irq_create_mapping to allocate a virtual Linux irq.

Those IRQs are not any more "virtual" than any other Linux IRQ
so I don't like this way of putting things. They are dynamically
allocated though.

The whole "virq" thing is just one big confusion, somehow people
are under the impression that some IRQ numbers in the kernel
are more "real" than others just because they happen to map
1-to-1 to a certain HW IRQ on the primary IRQ controller, but this
is just pure luck. This is one reason we're trying to get rid of
IRQ numbers altogether (if that will ever go anywhere).

> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
> ---
> v2-changes:
>  - reword the patch description

I applied v1 anyway.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/