linux-kernel - Re: [PATCH 18/34] mlx4: Use pci_enable_msix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52EBF7DE.3080003@cogentembedded.com>
Date:	Fri, 31 Jan 2014 22:22:06 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Alexander Gordeev <agordeev@...hat.com>,
	linux-kernel@...r.kernel.org
CC:	"David S. Miller" <davem@...emloft.net>,
	Amir Vadai <amirv@...lanox.com>, netdev@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 18/34] mlx4: Use pci_enable_msix_range()

Hello.

On 01/31/2014 06:08 PM, Alexander Gordeev wrote:

> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() and pci_enable_msix_range()
> interfaces.

> Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/main.c |   19 ++++---------------
>   1 files changed, 4 insertions(+), 15 deletions(-)

> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index d711158..a9d1249 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
[...]
> @@ -1990,22 +1989,12 @@ static void mlx4_enable_msi_x(struct mlx4_dev *dev)
[...]
> +		nreq = pci_enable_msix_range(dev->pdev, entries, 2, nreq);
> +
> +		if (nreq < 0) {
>   			kfree(entries);
>   			goto no_msi;
> -		}
> -
> -		if (nreq <
> +		} else if (nreq <
>   		    MSIX_LEGACY_SZ + dev->caps.num_ports * MIN_MSIX_P_PORT) {

    Please realign this line to start right under 'nreq'.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/