linux-kernel - Re: [PATCH] Drivers:staging:octeon-usb: Fixed Few coding style errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140131195353.GC589@drone.musicnaut.iki.fi>
Date:	Fri, 31 Jan 2014 21:53:53 +0200
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Surendra Patil <surendra.tux@...il.com>
Cc:	gregkh@...uxfoundation.org, devendra.aaru@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers:staging:octeon-usb: Fixed Few coding style errors

Hi,

On Thu, Jan 30, 2014 at 10:35:19PM -0800, Surendra Patil wrote:
> -	uint32_t reserved		: 25;
> -	uint32_t port_enabled		: 1;
> -	uint32_t port_over_current	: 1;
> -	uint32_t port_powered		: 1;
> -	enum cvmx_usb_speed port_speed	: 2;
> -	uint32_t connected		: 1;
> -	uint32_t connect_change		: 1;
> +	uint32_t reserved:25;
> +	uint32_t port_enabled:1;
> +	uint32_t port_over_current:1;
> +	uint32_t port_powered:1;
> +	enum cvmx_usb_speed port_speed:2;
> +	uint32_t connected:1;
> +	uint32_t connect_change:1;

Not an improvement, please don't do this.

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/