linux-kernel - Re: [PATCH] Fix mountpoint reference leakage in linkat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140131181129.2945f8aa@tlielax.poochiereds.net>
Date:	Fri, 31 Jan 2014 18:11:29 -0500
From:	Jeff Layton <jlayton@...hat.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Oleg Drokin <green@...uxhacker.ru>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] Fix mountpoint reference leakage in linkat

On Fri, 31 Jan 2014 22:30:14 +0000
Al Viro <viro@...IV.linux.org.uk> wrote:

> On Fri, Jan 31, 2014 at 04:32:31PM -0500, Jeff Layton wrote:
> 
> >  	done_path_create(&new_path, new_dentry);
> > +	path_put(&old_path);
> 
> ... and the filesystem in question isn't pinned anymore, so it can be
> unmounted, except that
> 
> >  	if (delegated_inode) {
> >  		error = break_deleg_wait(&delegated_inode);
> 
> this does an iput() on delegated_inode.  And umount really doesn't
> like finding pinned inodes.  Sorry, no go.
> 
> I'm going with Oleg's patch with second path_put() added.

Good point. I hadn't considered that. Oleg's second patch looks good to
me too.

-- 
Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/