lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Fri, 31 Jan 2014 15:44:58 -0800
From:	Zoran Markovic <>
Cc:	Shaibal Dutta <>,
	Ming Lei <>,
	Greg Kroah-Hartman <>,
	Zoran Markovic <>
Subject: [RFC PATCH] firmware: use power efficient workqueue for unloading and aborting fw load

From: Shaibal Dutta <>

Allow the scheduler to select the most appropriate CPU for running the
firmware load timeout routine and delayed routine for firmware unload.
This extends idle residency times and conserves power.

This functionality is enabled when CONFIG_WQ_POWER_EFFICIENT is selected.

Cc: Ming Lei <>
Cc: Greg Kroah-Hartman <>
Signed-off-by: Shaibal Dutta <>
[ Rebased to latest kernel, added commit message.
Fixed code alignment.]
Signed-off-by: Zoran Markovic <>
 drivers/base/firmware_class.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 8a97ddf..ae34219 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -900,7 +900,8 @@ static int _request_firmware_load(struct firmware_priv *fw_priv,
 		dev_set_uevent_suppress(f_dev, false);
 		dev_dbg(f_dev, "firmware: requesting %s\n", buf->fw_id);
 		if (timeout != MAX_SCHEDULE_TIMEOUT)
-			schedule_delayed_work(&fw_priv->timeout_work, timeout);
+			queue_delayed_work(system_power_efficient_wq,
+					   &fw_priv->timeout_work, timeout);
 		kobject_uevent(&fw_priv->dev.kobj, KOBJ_ADD);
@@ -1570,8 +1571,8 @@ static void device_uncache_fw_images_work(struct work_struct *work)
 static void device_uncache_fw_images_delay(unsigned long delay)
-	schedule_delayed_work(&,
-			msecs_to_jiffies(delay));
+	queue_delayed_work(system_power_efficient_wq, &,
+			   msecs_to_jiffies(delay));
 static int fw_pm_notify(struct notifier_block *notify_block,

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists