lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 1 Feb 2014 12:16:42 -0800
From:	Linus Torvalds <>
To:	"H. Peter Anvin" <>
Cc:	Suresh Siddha <>,
	Nate Eldredge <>,
	Thomas Gleixner <>,
	Ingo Molnar <>,
	"the arch/x86 maintainers" <>,
	stable <>,
	Linux Kernel Mailing List <>,
	Maarten Baert <>,
	Jan Kara <>, George Spelvin <>,
	Pekka Riikonen <>
Subject: Re: [PATCH] Make math_state_restore() save and restore the interrupt flag

On Sat, Feb 1, 2014 at 12:00 PM, H. Peter Anvin <> wrote:
> Of course, if we are really doing all eager fpu, we could just leave cr0.ts always clear and not touch it at all...

That's what the eager fpu code tries to do now (apart from process
initialization, I think). But the problem is that even disregarding
the process init issue, it saves and restores around every kernel FPU
use. What the extra flag (and task_work/do_resume_suspend) would do is
to just save/restore *once* per kernel entry.

Now, the *common* situation is certainly that the kernel doesn't do
any FPU work at all, but there are clearly exceptions to that. If
certain wireless encryption modes end up actually using hw
acceleration, we might have a *lot* of overhead from the save/restore
code. In fact, I think it triggers even for the idle task, which
doesn't really care.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists