lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 1 Feb 2014 23:13:34 +0900
From:	Hyong-Youb Kim <>
To:	Sergei Shtylyov <>,
	Alexander Gordeev <>,
CC:	Hyong-Youb Kim <>, <>,
Subject: Re: [PATCH 20/34] myri10ge: Use pci_enable_msix_range()

On 2/1/2014 4:24 AM, Sergei Shtylyov wrote:
> Hello.
> On 01/31/2014 06:08 PM, Alexander Gordeev wrote:
>> +        if (status < 0)
>> +            goto disable_msix;
>     Hm, if enabling MSI failed, we don't need to disable it, right? So,
> perhaps the label should be renamed?

The code following disable_msix does not call pci_disable_msix().  It 
frees the allocated vector buffer and loads the firmware that uses a 
single interrupt vector.  So, it is "disable" in the sense that the 
driver is not going to use MSI-X vectors.  I agree that naming could be 

         if (mgp->msix_vectors != NULL) {
                 mgp->msix_vectors = NULL;

         mgp->num_slices = 1;
         set_fw_name(mgp, old_fw, old_allocated);
         myri10ge_load_firmware(mgp, 0);
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists