linux-kernel - Re: [PATCH 6/8] cleanup __vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 2 Feb 2014 08:37:07 -0800
From:	Andy Lutomirski <luto@...capital.net>
To:	Stefani Seibold <stefani@...bold.net>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	X86 ML <x86@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Andi Kleen <ak@...ux.intel.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	John Stultz <john.stultz@...aro.org>,
	Pavel Emelyanov <xemul@...allels.com>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	andriy.shevchenko@...ux.intel.com, Martin.Runge@...de-schwarz.com,
	Andreas.Brief@...de-schwarz.com
Subject: Re: [PATCH 6/8] cleanup __vdso_gettimeofday

On Sun, Feb 2, 2014 at 3:27 AM,  <stefani@...bold.net> wrote:
> From: Stefani Seibold <stefani@...bold.net>
>
> This patch do a little cleanup for the __vdso_gettimeofday() function.
>
> It kick out an unneeded ret local variable and makes the code faster if
> only the timezone is needed.
>
> Signed-off-by: Stefani Seibold <stefani@...bold.net>

Acked-by: Andy Lutomirski <luto@...capital.net>

> ---
>  arch/x86/vdso/vclock_gettime.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/vdso/vclock_gettime.c b/arch/x86/vdso/vclock_gettime.c
> index 743f277..bf969a0 100644
> --- a/arch/x86/vdso/vclock_gettime.c
> +++ b/arch/x86/vdso/vclock_gettime.c
> @@ -259,13 +259,12 @@ int clock_gettime(clockid_t, struct timespec *)
>
>  notrace int __vdso_gettimeofday(struct timeval *tv, struct timezone *tz)
>  {
> -       long ret = VCLOCK_NONE;
> -
>         if (likely(tv != NULL)) {
>                 BUILD_BUG_ON(offsetof(struct timeval, tv_usec) !=
>                              offsetof(struct timespec, tv_nsec) ||
>                              sizeof(*tv) != sizeof(struct timespec));
> -               ret = do_realtime((struct timespec *)tv);
> +               if (do_realtime((struct timespec *)tv) == VCLOCK_NONE)
> +                       return vdso_fallback_gtod(tv, tz);
>                 tv->tv_usec /= 1000;
>         }
>         if (unlikely(tz != NULL)) {
> @@ -274,8 +273,6 @@ notrace int __vdso_gettimeofday(struct timeval *tv, struct timezone *tz)
>                 tz->tz_dsttime = gtod->sys_tz.tz_dsttime;
>         }
>
> -       if (ret == VCLOCK_NONE)
> -               return vdso_fallback_gtod(tv, tz);
>         return 0;
>  }
>  int gettimeofday(struct timeval *, struct timezone *)
> --
> 1.8.5.3
>



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/