linux-kernel - RE: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D0F6B772B@AcuExch.aculab.com>
Date:	Mon, 3 Feb 2014 10:05:14 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Dan Carpenter' <dan.carpenter@...cle.com>,
	Chen Gang <gang.chen.5i5j@...il.com>
CC:	James Hogan <james.hogan@...tec.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"andreas.dilger@...el.com" <andreas.dilger@...el.com>,
	Antonio Quartulli <antonio@...hcoding.com>,
	"Greg KH" <gregkh@...uxfoundation.org>,
	"bergwolf@...il.com" <bergwolf@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	"oleg.drokin@...el.com" <oleg.drokin@...el.com>,
	"jacques-charles.lafoucriere@....fr" 
	<jacques-charles.lafoucriere@....fr>,
	"jinshan.xiong@...el.com" <jinshan.xiong@...el.com>,
	netdev <netdev@...r.kernel.org>,
	"linux-metag@...r.kernel.org" <linux-metag@...r.kernel.org>
Subject: RE: [PATCH] drivers: staging: lustre: lustre: include: add
 "__attribute__((packed))" for the related union

From: Dan Carpenter
> On Sat, Feb 01, 2014 at 09:57:39PM +0800, Chen Gang wrote:
> > It seems, our kernel still stick to treate 'pack' region have effect
> > with both 'align' and 'sizeof'.
> 
> It's not about packed regions.  It's about unions.  It's saying the
> sizeof() a union is a multiple of 4 unless it's packed.
> 
> union foo {
> 	short x;
> 	short y;
> };
> 
> The author intended the sizeof(union foo) to be 2 but on metag arch then
> it is 4.

The same is probably be true of: struct foo { _u16 bar; };

Architectures that define such alignment rules are a right PITA.
You either need to get the size to 2 without using 'packed', or
just not define such structures.
It is worth seeing if adding aligned(2) will change the size - I'm
not sure.

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/