linux-kernel - Re: [PATCH] cpufreq: cpu0: make THERMAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Feb 2014 10:14:40 -0600
From:	Rob Herring <robherring2@...il.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Eduardo Valentin <eduardo.valentin@...com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Olof Johansson <olof@...om.net>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: cpu0: make THERMAL_CPU support optional

On Mon, Feb 3, 2014 at 12:05 AM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> Cc'ing the guy who introduced this bug..
>
> On 2 February 2014 04:20, Rob Herring <robherring2@...il.com> wrote:
>> From: Rob Herring <robh@...nel.org>
>>
>> The addition of THERMAL and THERMAL_CPU selections causes a kconfig
>> warning on highbank platforms:
>>
>> warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has
>> unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK &&
>>  REGULATOR && OF && THERMAL && CPU_THERMAL)
>>
>> The cpufreq-cpu0 driver does not require thermal zone support, and it
>> should be selectable independently. Add a new kconfig option to enable
>> this feature.
>>
>> Reported-by: Olof Johansson <olof@...om.net>
>> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
>> Cc: Viresh Kumar <viresh.kumar@...aro.org>
>> Cc: cpufreq@...r.kernel.org
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> ---
>>  drivers/cpufreq/Kconfig | 10 +++++++++-
>>  1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
>> index 4b029c0..a197a04a 100644
>> --- a/drivers/cpufreq/Kconfig
>> +++ b/drivers/cpufreq/Kconfig
>> @@ -185,7 +185,7 @@ config CPU_FREQ_GOV_CONSERVATIVE
>>
>>  config GENERIC_CPUFREQ_CPU0
>>         tristate "Generic CPU0 cpufreq driver"
>> -       depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL
>> +       depends on HAVE_CLK && REGULATOR && OF
>
> That's fine as code would still compile due to dummy routines..
>
>>         select PM_OPP
>>         help
>>           This adds a generic cpufreq driver for CPU0 frequency management.
>> @@ -194,6 +194,14 @@ config GENERIC_CPUFREQ_CPU0
>>
>>           If in doubt, say N.
>>
>> +config GENERIC_CPUFREQ_CPU0_THERMAL
>> +       bool "Thermal zone support for Generic CPU0 cpufreq"
>> +       depends on GENERIC_CPUFREQ_CPU0
>> +       select THERMAL
>> +       select THERMAL_CPU
>> +       help
>> +         This adds thermal support to the generic cpufreq driver for CPU0.
>
> But do we really need this? Let the platform enable THERMAL
> and THERMAL_CPU themselves, as this was the case currently.

That's certainly fine by me, but I don't know which platforms those are.

BTW, REGULATOR could probably be dropped as well. It certainly works
w/o a regulator as highbank does not define one.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/