linux-kernel - Re: [PATCH -v2] x86, microcode, AMD: Sanity-check initrd image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Feb 2014 21:33:23 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH -v2] x86, microcode, AMD: Sanity-check initrd image

On Mon, Feb 03, 2014 at 03:28:51PM -0500, Boris Ostrovsky wrote:
> On 02/03/2014 02:52 PM, Borislav Petkov wrote:
> >On Mon, Feb 03, 2014 at 02:37:34PM -0500, Boris Ostrovsky wrote:
> >>It exploded when 'if (!container)' check was done *after* relocation,
> >>which made container non-zero. If you do the check *before* then I
> >>think you will catch the fact that container is empty.
> >Ah, right, this was it.
> >
> >Ok, just remove the signature check then and give it a try pls:
> 
> Yes, this fixes the bug. And it loads microcode for a good binary.
> 
> For these two patches:
> Tested-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> 
> (You might want to rename the final patch to something else since
> you are not checking the blob anymore).

Yes, will do. It'll be one patch though - it is still small enough. I'll
send it as a reply to this message.

Thanks for your help!

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/