linux-kernel - Re: [PATCH v5 4/6] spmi: pmic_arb: add support for interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140204205714.GN20228@joshc.qualcomm.com>
Date:	Tue, 4 Feb 2014 14:57:14 -0600
From:	Josh Cartwright <joshc@...eaurora.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-arm-msm@...r.kernel.org,
	Sagar Dharia <sdharia@...eaurora.org>,
	Gilad Avidov <gavidov@...eaurora.org>,
	Michael Bohan <mbohan@...eaurora.org>
Subject: Re: [PATCH v5 4/6] spmi: pmic_arb: add support for interrupt handling

On Tue, Feb 04, 2014 at 09:10:45PM +0100, Thomas Gleixner wrote:
> On Mon, 3 Feb 2014, Josh Cartwright wrote:
> > +static void qpnpint_irq_ack(struct irq_data *d)
> > +{
> > +	struct spmi_pmic_arb_dev *pa = irq_data_get_irq_chip_data(d);
> > +	u8 irq  = d->hwirq >> 8;
> > +	u8 apid = d->hwirq;
> > +	unsigned long flags;
> > +	u8 data;
> > +
> > +	spin_lock_irqsave(&pa->lock, flags);
> 
> This wants to be a raw_spinlock - think about RT!

Indeed.  I'll change this in the next revision.

> Looks sane otherwise.

Great, thanks for taking a look!

  Josh

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/