lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Feb 2014 18:06:47 +0530 From: Balaji T K <balajitk@...com> To: Tony Lindgren <tony@...mide.com>, <linux@....linux.org.uk> CC: <linux-mmc@...r.kernel.org>, <linux-omap@...r.kernel.org>, <geert@...ux-m68k.org>, <chris@...ntf.net>, <a-bindra@...com>, <linux-sh@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH/RFC] dmaengine: omap-dma: split header file On Friday 24 January 2014 10:21 PM, Balaji T K wrote: > To Resolve build failure seen with sh-allmodconfig: > include/linux/omap-dma.h:171:8: error: expected identifier before numeric constant > make[4]: *** [drivers/mmc/host/omap_hsmmc.o] Error 1 > due to CCR redefinition, move dmaengine consumer specific function to omap-dmaengine.h > > Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org> > Signed-off-by: Balaji T K <balajitk@...com> Hi Russell, Ping, If this patch looks OK, I can drop RFC and post as Patch, let me know. Thanks and Regards, Balaji T K > --- > drivers/mmc/host/omap_hsmmc.c | 2 +- > include/linux/omap-dma.h | 19 +------------------ > include/linux/omap-dmaengine.h | 21 +++++++++++++++++++++ > 3 files changed, 23 insertions(+), 19 deletions(-) > create mode 100644 include/linux/omap-dmaengine.h > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index dbd32ad..2f57e36 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -31,7 +31,7 @@ > #include <linux/of.h> > #include <linux/of_gpio.h> > #include <linux/of_device.h> > -#include <linux/omap-dma.h> > +#include <linux/omap-dmaengine.h> > #include <linux/mmc/host.h> > #include <linux/mmc/core.h> > #include <linux/mmc/mmc.h> > diff --git a/include/linux/omap-dma.h b/include/linux/omap-dma.h > index 7af25a9..6aa97e5 100644 > --- a/include/linux/omap-dma.h > +++ b/include/linux/omap-dma.h > @@ -1,23 +1,6 @@ > -/* > - * OMAP DMA Engine support > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - */ > #ifndef __LINUX_OMAP_DMA_H > #define __LINUX_OMAP_DMA_H > - > -struct dma_chan; > - > -#if defined(CONFIG_DMA_OMAP) || defined(CONFIG_DMA_OMAP_MODULE) > -bool omap_dma_filter_fn(struct dma_chan *, void *); > -#else > -static inline bool omap_dma_filter_fn(struct dma_chan *c, void *d) > -{ > - return false; > -} > -#endif > +#include <linux/omap-dmaengine.h> > > /* > * Legacy OMAP DMA handling defines and functions > diff --git a/include/linux/omap-dmaengine.h b/include/linux/omap-dmaengine.h > new file mode 100644 > index 0000000..2b0b6aa > --- /dev/null > +++ b/include/linux/omap-dmaengine.h > @@ -0,0 +1,21 @@ > +/* > + * OMAP DMA Engine support > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > +#ifndef __LINUX_OMAP_DMAENGINE_H > +#define __LINUX_OMAP_DMAENGINE_H > + > +struct dma_chan; > + > +#if defined(CONFIG_DMA_OMAP) || defined(CONFIG_DMA_OMAP_MODULE) > +bool omap_dma_filter_fn(struct dma_chan *, void *); > +#else > +static inline bool omap_dma_filter_fn(struct dma_chan *c, void *d) > +{ > + return false; > +} > +#endif > +#endif /* __LINUX_OMAP_DMAENGINE_H */ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists