linux-kernel - Re: + mm-utilc-add-kstrimdup.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140203184245.33ac93bf.akpm@linux-foundation.org>
Date:	Mon, 3 Feb 2014 18:42:45 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Sebastian Capella <sebastian.capella@...aro.org>
Cc:	David Rientjes <rientjes@...gle.com>,
	"Alexey Dobriyan" <adobriyan@...il.com>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>,
	mm-commits@...r.kernel.org, "Joe Perches" <joe@...ches.com>
Subject: Re: + mm-utilc-add-kstrimdup.patch added to -mm tree

On Mon, 03 Feb 2014 17:28:16 -0800 Sebastian Capella <sebastian.capella@...aro.org> wrote:

> Quoting David Rientjes (2014-02-03 17:05:04)
> > The last we heard, I think Sebastian is looking to redo this series and 
> > this patch is no longer needed.  Sebastian?
> Hi David, Alexey,
> 
> I am in the process of reworking the patches.  I'm not sure if Andrew
> was just interested in having the kstrimdup utility function available.
> 
> Isn't it too late to impose userspace trimming of newlines for sysfs?
> It seems already fairly common and expected for the kernel to eat the
> trailing whitespace, or at least ignore it.  If we change this won't we
> be breaking userspace / tools / instructions / etc?
> 

We have quite a lot of codesites which open-code the newline trimming. 
Providing a library function to do this will result in goodness.

That being said, I don't plan to merge kstrimdup() until it has some users.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/