| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140204163210.GQ6963@cmpxchg.org> Date: Tue, 4 Feb 2014 11:32:10 -0500 From: Johannes Weiner <hannes@...xchg.org> To: Michal Hocko <mhocko@...e.cz> Cc: Andrew Morton <akpm@...ux-foundation.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org Subject: Re: [PATCH -v2 5/6] memcg, kmem: clean up memcg parameter handling On Tue, Feb 04, 2014 at 02:28:59PM +0100, Michal Hocko wrote: > memcg_kmem_newpage_charge doesn't always set the given memcg parameter. lol, I really don't get your patch order... > Some early escape paths skip setting *memcg while > __memcg_kmem_newpage_charge down the call chain sets *memcg even if no > memcg is charged due to other escape paths. > > The current code is correct because the memcg is initialized to NULL > at the highest level in __alloc_pages_nodemask but this all is very > confusing and error prone. Let's make the semantic clear and move the > memcg parameter initialization to the highest level of kmem accounting > (memcg_kmem_newpage_charge). > > Signed-off-by: Michal Hocko <mhocko@...e.cz> Patch looks good, though. Acked-by: Johannes Weiner <hannes@...xchg.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists