linux-kernel - Re: [PATCH -v2 5/6] memcg, kmem: clean up memcg parameter handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140204164243.GQ4890@dhcp22.suse.cz>
Date:	Tue, 4 Feb 2014 17:42:43 +0100
From:	Michal Hocko <mhocko@...e.cz>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org
Subject: Re: [PATCH -v2 5/6] memcg, kmem: clean up memcg parameter handling

On Tue 04-02-14 11:32:10, Johannes Weiner wrote:
> On Tue, Feb 04, 2014 at 02:28:59PM +0100, Michal Hocko wrote:
> > memcg_kmem_newpage_charge doesn't always set the given memcg parameter.
> 
> lol, I really don't get your patch order...

Ok, Ok, I've encountered this mess while double checking #2 and was too
lazy to rebasing again. I will move it to the front for the merge.

> > Some early escape paths skip setting *memcg while
> > __memcg_kmem_newpage_charge down the call chain sets *memcg even if no
> > memcg is charged due to other escape paths.
> > 
> > The current code is correct because the memcg is initialized to NULL
> > at the highest level in __alloc_pages_nodemask but this all is very
> > confusing and error prone. Let's make the semantic clear and move the
> > memcg parameter initialization to the highest level of kmem accounting
> > (memcg_kmem_newpage_charge).
> > 
> > Signed-off-by: Michal Hocko <mhocko@...e.cz>
> 
> Patch looks good, though.
> 
> Acked-by: Johannes Weiner <hannes@...xchg.org>

Thanks!

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/