linux-kernel - Re: [PATCH] regulator: gpio: bugfix: add gpios-status for DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140204184327.GS22609@sirena.org.uk>
Date:	Tue, 4 Feb 2014 18:43:27 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Kuninori Morimoto <kuninori.morimoto.gx@...il.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Lee Jones <lee.jones@...aro.org>, Simon <horms@...ge.net.au>,
	Magnus <magnus.damm@...il.com>,
	Linux-SH <linux-sh@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: gpio: bugfix: add gpios-status for DT

On Thu, Jan 30, 2014 at 09:25:14PM -0800, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> 
> config->gpios[x].flags indicates initial pin status,
> and it will be used for drvdata->state
> on gpio_regulator_probe().

I've applied this, thanks.  However, a couple of things that it'd be
nice to improve with followup patches:

> +- gpios-states		: gpios pin's initial states. 1 means HIGH

A mention that this is an array of values would be good (it's clear from
the code but not from the document), as would saying that the defualt is
low if nothing is specified.

> +		if (proplen != config->nr_gpios) {
> +			/* gpios <-> gpios-states mismatch */
> +			prop = NULL;
> +		}
> +	}

It's probably worth printing a warning here.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)