linux-kernel - RE: [PATCH v1] clocksource: tegra: Add nvidia,tegra30-timer compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1402042004000.24986@ionos.tec.linutronix.de>
Date:	Tue, 4 Feb 2014 20:10:05 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andrew Chew <AChew@...dia.com>
cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	"swarren@...dotorg.org" <swarren@...dotorg.org>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>,
	"abrestic@...omium.org" <abrestic@...omium.org>,
	"dgreid@...omium.org" <dgreid@...omium.org>,
	"katierh@...omium.org" <katierh@...omium.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: RE: [PATCH v1] clocksource: tegra: Add nvidia,tegra30-timer compat

On Mon, 3 Feb 2014, Andrew Chew wrote:

> > From: Daniel Lezcano [mailto:daniel.lezcano@...aro.org]
> > Sent: Monday, February 03, 2014 8:40 AM
> > To: Andrew Chew; tglx@...utronix.de; swarren@...dotorg.org;
> > thierry.reding@...il.com; abrestic@...omium.org; dgreid@...omium.org;
> > katierh@...omium.org
> > Cc: linux-kernel@...r.kernel.org; linux-tegra@...r.kernel.org
> > Subject: Re: [PATCH v1] clocksource: tegra: Add nvidia,tegra30-timer compat
> > 
> > On 01/31/2014 10:29 PM, Andrew Chew wrote:
> > > There are some differences between tegra20's timer registers and
> > > tegra30's (and later).  For one thing, the watchdogs don't seem to be
> > > present in tegra20.
> > 
> > "don't seem", so it is an assumption ?
> 
> No, this is not an assumption.  It has been verified by other NVIDIA engineers
> since I proposed this change.

So why is your changelog saying "don't seem to be" ?
  
> > > Add this compatibility string in order to be able to distinguish
> > > whether the watchdogs are there or not.
> > 
> > Sorry but I don't get the connection between declaring the tegra30_timer
> > and the log. Can you elaborate please ?
> 
> I don't know what you mean by "the log".  Was that a typo?  Anyway, I

Daniel refers to the changelog.

> have a watchdog driver that I intend to follow up with, that binds
> with tegra30-timer.  I don't want this driver to be able to bind with
> tegra20-timer, because the driver won't actually work on tegra20.

So the changelog should say:

  Tegra30 and later have more timer functionality than Tegra20, but
  share the clocksource core code.

  Add a separate devicetree entry which defaults to the tegra20 code
  for now. This is preparatory work for adding new tegra30 specific
  functionality.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/