linux-kernel - RE: [PATCH v1] clocksource: tegra: Add nvidia,tegra30-timer compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1402042122320.24986@ionos.tec.linutronix.de>
Date:	Tue, 4 Feb 2014 21:22:50 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andrew Chew <AChew@...dia.com>
cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	"swarren@...dotorg.org" <swarren@...dotorg.org>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>,
	"abrestic@...omium.org" <abrestic@...omium.org>,
	"dgreid@...omium.org" <dgreid@...omium.org>,
	"katierh@...omium.org" <katierh@...omium.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: RE: [PATCH v1] clocksource: tegra: Add nvidia,tegra30-timer compat

On Tue, 4 Feb 2014, Andrew Chew wrote:

> > > > On 01/31/2014 10:29 PM, Andrew Chew wrote:
> > > > > There are some differences between tegra20's timer registers and
> > > > > tegra30's (and later).  For one thing, the watchdogs don't seem to
> > > > > be present in tegra20.
> > > >
> > > > "don't seem", so it is an assumption ?
> > >
> > > No, this is not an assumption.  It has been verified by other NVIDIA
> > > engineers since I proposed this change.
> > 
> > So why is your changelog saying "don't seem to be" ?
> 
> I updated the commit message (see V2 of this patch).  I hope the new
> commit message satisfies the concerns:
> 
> "There are some differences between tegra20's timer registers and tegra30's
> (and later).  For example, tegra30 has more timers.  In addition, watchdogs are
> not present in tegra20.
> 
> Add this compatibility string in order to be able to distinguish whether the
> additional timers and watchdogs are there or not."

Yup, that's way more understandable.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/