linux-kernel - Re: [PATCH 22/22] vmw_pvscsi: Use pci_enable_msix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1720135544.11645858.1391550424291.JavaMail.root@vmware.com>
Date:	Tue, 4 Feb 2014 13:47:04 -0800 (PST)
From:	Arvind Kumar <arvindkumar@...are.com>
To:	Alexander Gordeev <agordeev@...hat.com>
Cc:	linux-kernel@...r.kernel.org, pv-drivers@...are.com,
	linux-scsi@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 22/22] vmw_pvscsi: Use pci_enable_msix_range()

Looks fine to me.

Acked-by: Arvind Kumar <arvindkumar@...are.com>

Thanks!
Arvind

----- Original Message -----
From: "Alexander Gordeev" <agordeev@...hat.com>
To: linux-kernel@...r.kernel.org
Cc: "Alexander Gordeev" <agordeev@...hat.com>, "Arvind Kumar" <arvindkumar@...are.com>, pv-drivers@...are.com, linux-scsi@...r.kernel.org, linux-pci@...r.kernel.org
Sent: Tuesday, February 4, 2014 3:17:08 AM
Subject: [PATCH 22/22] vmw_pvscsi: Use pci_enable_msix_range()

As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() and pci_enable_msix_range()
interfaces.

Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
Cc: Arvind Kumar <arvindkumar@...are.com>
Cc: pv-drivers@...are.com
Cc: linux-scsi@...r.kernel.org
Cc: linux-pci@...r.kernel.org
---
 drivers/scsi/vmw_pvscsi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index b9755ec..c521f8e 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -1078,8 +1078,8 @@ static int pvscsi_setup_msix(const struct pvscsi_adapter *adapter,
 	struct msix_entry entry = { 0, PVSCSI_VECTOR_COMPLETION };
 	int ret;
 
-	ret = pci_enable_msix(adapter->dev, &entry, 1);
-	if (ret)
+	ret = pci_enable_msix_range(adapter->dev, &entry, 1, 1);
+	if (ret < 0)
 		return ret;
 
 	*irq = entry.vector;
-- 
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/