linux-kernel - Re: [PATCHv3 6/8] zram: report failed read and write stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140205095211.GA2200@swordfish.minsk.epam.com>
Date:	Wed, 5 Feb 2014 12:52:11 +0300
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Minchan Kim <minchan@...nel.org>,
	Jerome Marchand <jmarchan@...hat.com>,
	Nitin Gupta <ngupta@...are.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 6/8] zram: report failed read and write stats

On (02/04/14 14:18), Andrew Morton wrote:
> Date: Tue, 4 Feb 2014 14:18:49 -0800
> From: Andrew Morton <akpm@...ux-foundation.org>
> To: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Cc: Minchan Kim <minchan@...nel.org>, Jerome Marchand
>  <jmarchan@...hat.com>, Nitin Gupta <ngupta@...are.org>,
>  linux-kernel@...r.kernel.org
> Subject: Re: [PATCHv3 6/8] zram: report failed read and write stats
> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu)
> 
> On Thu, 16 Jan 2014 16:12:14 +0300 Sergey Senozhatsky <sergey.senozhatsky@...il.com> wrote:
> 
> > zram accounted but did not report numbers of failed read
> > and write queries. make these stats available as failed_reads
> > and failed_writes attrs.
> > 
> > Acked-by: Minchan Kim <minchan@...nel.org>
> > Acked-by: Jerome Marchand <jmarchan@...hat.com>
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > ---
> >  drivers/block/zram/zram_drv.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> > index e7102f1..9d67fbf 100644
> > --- a/drivers/block/zram/zram_drv.c
> > +++ b/drivers/block/zram/zram_drv.c
> > @@ -728,6 +728,8 @@ static DEVICE_ATTR(mem_used_total, S_IRUGO, mem_used_total_show, NULL);
> >  
> >  ZRAM_ATTR_RO(num_reads);
> >  ZRAM_ATTR_RO(num_writes);
> > +ZRAM_ATTR_RO(failed_reads);
> > +ZRAM_ATTR_RO(failed_writes);
> >  ZRAM_ATTR_RO(invalid_io);
> >  ZRAM_ATTR_RO(notify_free);
> >  ZRAM_ATTR_RO(zero_pages);
> > @@ -739,6 +741,8 @@ static struct attribute *zram_disk_attrs[] = {
> >  	&dev_attr_reset.attr,
> >  	&dev_attr_num_reads.attr,
> >  	&dev_attr_num_writes.attr,
> > +	&dev_attr_failed_reads.attr,
> > +	&dev_attr_failed_writes.attr,
> >  	&dev_attr_invalid_io.attr,
> >  	&dev_attr_notify_free.attr,
> >  	&dev_attr_zero_pages.attr,
> 
> Documentation/blockdev/zram.txt and
> Documentation/ABI/testing/sysfs-block-zram need updating...
> 

Hello,
sure, will update.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/