linux-kernel - Re: [PATCH] perf tools: Handle PERF_RECORD_HEADER_EVENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140205132450.GA3685@infradead.org>
Date:	Wed, 5 Feb 2014 11:24:50 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH] perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly

Em Wed, Feb 05, 2014 at 10:03:39AM +0100, Jiri Olsa escreveu:
> On Wed, Feb 05, 2014 at 06:55:52AM +0100, Ingo Molnar wrote:
> > 
> > * Jiri Olsa <jolsa@...hat.com> wrote:
> > 
> > > We removed event types from data file in following commits:
> > >   6065210 perf tools: Remove event types framework completely
> > >   44b3c57 perf tools: Remove event types from perf data file
> > > 
> > > We no longer need this information, because we can get it
> > > directly from tracepoints.
> > > 
> > > But we still need to handle PERF_RECORD_HEADER_EVENT_TYPE
> > > event for the sake of old perf data files created in pipe
> > > mode like:
> > > 
> > >   $ perf.3.4 record -o - foo >perf.data
> > >   $ perf.312 report -i - < perf.data
> > > 
> > > Reported-by: Stephane Eranian <eranian@...gle.com>
> > > Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> > > Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com>
> > > Cc: Frederic Weisbecker <fweisbec@...il.com>
> > > Cc: Ingo Molnar <mingo@...e.hu>
> > > Cc: Namhyung Kim <namhyung@...nel.org>
> > > Cc: Paul Mackerras <paulus@...ba.org>
> > > Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > > Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> > > Cc: David Ahern <dsahern@...il.com>
> > > ---
> > >  tools/perf/util/session.c | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> > > index 0b39a48..5da6ce7 100644
> > > --- a/tools/perf/util/session.c
> > > +++ b/tools/perf/util/session.c
> > > @@ -1008,6 +1008,12 @@ static int perf_session__process_user_event(struct perf_session *session, union
> > >  		if (err == 0)
> > >  			perf_session__set_id_hdr_size(session);
> > >  		return err;
> > > +	case PERF_RECORD_HEADER_EVENT_TYPE:
> > > +		/*
> > > +		 * Depreceated, but we need to handle it for sake
> > > +		 * of old data files create in pipe mode.
> > > +		 */
> > 
> > Two small speling nits:
> > 
> >  s/Depreceated
> >   /Deprecated
> > 
> >  s/create
> >   /created
> > 
> > Ack otherwise.
> > 
> > Thanks,
> > 
> > 	Ingo
> 
> ugh, my spell checker sux.. ;-\ acme, beer for each correction? ;-)

two for each, deal.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/