linux-kernel - Re: [PATCH v2 1/3] clocksource: tegra: Add nvidia,tegra30-timer compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52F2996B.4080005@wwwdotorg.org>
Date:	Wed, 05 Feb 2014 13:04:59 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Andrew Chew <achew@...dia.com>, daniel.lezcano@...aro.org,
	tglx@...utronix.de, thierry.reding@...il.com, rob@...dley.net,
	grant.likely@...aro.org, robh+dt@...nel.org, abrestic@...omium.org,
	dgreid@...omium.org, katierh@...omium.org
CC:	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-watchdog@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 1/3] clocksource: tegra: Add nvidia,tegra30-timer compat

On 02/03/2014 05:17 PM, Andrew Chew wrote:
> There are some differences between tegra20's timer registers and tegra30's
> (and later).  For example, tegra30 has more timers.  In addition, watchdogs
> are not present in tegra20.
> 
> Add this compatibility string in order to be able to distinguish
> whether the additional timers and watchdogs are there or not.

> diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksource/tegra20_timer.c

>  CLOCKSOURCE_OF_DECLARE(tegra20_timer, "nvidia,tegra20-timer", tegra20_init_timer);
> +CLOCKSOURCE_OF_DECLARE(tegra30_timer, "nvidia,tegra30-timer", tegra20_init_timer);

Thinking about this more, nothing in this driver actually cares about
Tegra20 vs. Tegra30+, since the timer that's used is present in all
chips. Hence, this patch isn't needed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/